plugins: keepkey: vendor keepkeylib #9581
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is from PyPI, keepkey==6.3.1 [0] with sha256 hash `cef1e862e195ece3e42640a0f57d15a63086fd1dedc8b5ddfcbc9c2657f0bb1e`, which is the hash we've had pinned in contrib/deterministic-build/requirements-hw.txt for 5 years. [0]: https://files.pythonhosted.org/packages/30/38/558d9a2dd1fd74f50ff4587b4054496ffb69e21ab1138eb448f3e8e2f4a7/keepkey-6.3.1.tar.gz related spesmilo#7922 and keepkey/python-keepkey#146 (i.e. upstream keepkeylib is unmaintained)
``` $ mkdir -p /opt/protoc && \ curl -L0 https://github.com/protocolbuffers/protobuf/releases/download/v21.12/protoc-21.12-linux-x86_64.zip -o /tmp/protoc-21.12-linux-x86_64.zip && \ unzip /tmp/protoc-21.12-linux-x86_64.zip -d /opt/protoc $ PATH="/opt/protoc/bin:$PATH" $ ~/wspace/electrum/electrum/plugins/keepkey/device-protocol/build_pb.sh ```
now that the keepkey pb2's are regenerated using the "new" format, we don't need an old python3-protobuf to parse them ref spesmilo#7922
|
note: we could alternatively make this a git submodule, or we could also just rm the keepkey support. |
Hmm, looks like there is actually some recent work in branches: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds keepkeylib into our git tree. We will vendor it that way from now, instead of declaring it as an external dependency.
Upstream keepkeylib is effectively unmaintained -- but the only problem with it is that it requires an old version of
protobuf. (see keepkey/python-keepkey#146)By vendoring it, we can fix that ourselves.
keepkeylib is taken from PyPI, at keepkey==6.3.1, which is the version we have sha256 pinned for 5 years.
This also vendors the corresponding source protobuf files, which were not part of the keepkeylib sdist. Those are taken from the git repo, at the corresponding commit (for v6.3.1).
Subsequent commits
protoc-21.12(which is the version currently in debian stable, already much newer than what was previously used)closes #7922